Add tests for assert, abort, and environ.#105
Merged
sunfishcode merged 1 commit intomasterfrom Mar 11, 2020
Merged
Conversation
To support this, add a mechanism for filtering test output to filter out uninteresting diffs. This adds some coverage for the code being changed in WebAssembly/wasi-libc#184.
pchickey
approved these changes
Mar 11, 2020
Collaborator
pchickey
left a comment
There was a problem hiding this comment.
Beautiful, thank you for adding these
sbc100
reviewed
Mar 17, 2020
| Caused by: | ||
| 0: failed to invoke `_start` | ||
| 1: wasm trap: unreachable, source location: @---- | ||
| wasm backtrace: |
Member
There was a problem hiding this comment.
Where is this output coming from? Is it coming from some wasmtime-internal place?
Member
Author
There was a problem hiding this comment.
Yeah. If other engines have a different format, we can adjust the filter script as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support this, add a mechanism for filtering test output to filter
out uninteresting diffs.
This adds some coverage for the code being changed in
WebAssembly/wasi-libc#184.