Fix for empty CMAKE_OSX_SYSROOT #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have started happening in on the macos-latest CI machine. Seems better to check for empty string since apparently that is what it gets set to in cmake 4.0: https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html: "Changed in version 4.0: The default is now empty. Previously a default was computed based on the CMAKE_OSX_DEPLOYMENT_TARGET or the host platform."
keithw
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have started happening in on the macos-latest CI machine. Seems better to check for empty string since apparently that is what it gets set to in cmake 4.0:
https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html:
"Changed in version 4.0: The default is now empty. Previously a default was computed based on the CMAKE_OSX_DEPLOYMENT_TARGET or the host platform."
It looks like there is another issue that is causing some tests to fail on macos-latest (
sigaltstack: Invalid argument) but I proposal that we fix that in a separate PR.