gh-2616 Fix wrong validation of code metadata function index #2617
+127
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! wasm-tools seems to have some tests for metadata annotations (e.g. https://github.com/bytecodealliance/wasm-tools/tree/main/tests/cli/branch-hinting) -- is it possible to port over some of those tests? That would give some more assurance that we are parsing this as intended (or at least as other consumers do). |
Contributor
Author
|
About the tests: sure! I'll see what I can do :) |
Contributor
Author
|
Since their case mostly validates proper parsing of the hints, I combined their test cases into a wat2wasm + objdump test case. |
sbc100
approved these changes
Jun 17, 2025
Contributor
Author
|
Alright. Now that all tests are passing, this should be ready for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2616