Fix lint task #2546
Merged
Fix lint task #2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git clang-format appears to now return an exit status instead of always succeeding, and the change broke the script. so, just make it always succeed again.
sbc100
reviewed
Feb 18, 2025
sbc100
approved these changes
Feb 18, 2025
scripts/clang-format-diff.sh
Outdated
| FORMAT_MSG=$(git clang-format $MERGE_BASE -q --diff -- src/ || true) | ||
| if [ -n "$FORMAT_MSG" -a "$FORMAT_MSG" != "no modified files to format" ] | ||
| if ! git clang-format $MERGE_BASE -q --diff -- src/ 2>&1 >/dev/null | ||
| then |
Member
There was a problem hiding this comment.
Can you move this ; then to the line above?
sbc100
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git clang-format appears to now return an exit status instead of always succeeding, and the change broke the script. this fixes it.