CI: Use safer GITHUB_OUTPUT #2540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Feb 13, 2025
Member
sbc100
left a comment
There was a problem hiding this comment.
Is there some way we can test this or confirm its correct? Or do we just need to wait for a release?
Collaborator
Author
|
the wasi job uploads artifacts, which is how we came across the deprecation warnings. and it seems to be still working. you can see them here: https://github.com/WebAssembly/wabt/actions/runs/13314673812/attempts/1?pr=2540 |
Collaborator
Author
|
(we hope that s390x failure was some sort of spurious bitflip...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently this is a thing https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
tho they did go back on it https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/
but it seems like a good idea to switch anyway