Fix call_ref on empty stack #2472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
sbc100
reviewed
Sep 24, 2024
| PrintError("%s", message.c_str()); | ||
| result = Result::Error; | ||
| Result result = PeekType(0, &type); | ||
| if (!type.IsReferenceWithIndex()) { |
Member
There was a problem hiding this comment.
Is it OK to use type here even if PeekType fails? i.e. should we return early if PeekType fails?
Collaborator
Author
There was a problem hiding this comment.
yeah this is fine. PeekType will set type to Type::Any, this is the same logic as the fix in #2471 - we want the error message.
sbc100
approved these changes
Sep 24, 2024
Collaborator
Author
|
(you'll have to rebase it) |
Collaborator
Author
|
(actually we'll rebase it) |
auto-merge was automatically disabled
September 24, 2024 17:29
Head branch was pushed to by a user without write access
d45640e to
b9c687f
Compare
Collaborator
Author
|
(you'll have to re-enable auto-merge tho) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as #2471 but for
call_ref.We don't believe there's a prior issue for this.