Skip to content

Conversation

@keithw
Copy link
Member

@keithw keithw commented May 12, 2023

I think we're ready to tag 1.0.33 now.

@keithw keithw requested a review from sbc100 May 12, 2023 20:21
@keithw
Copy link
Member Author

keithw commented May 12, 2023

Thank you! Please feel free to merge and do the release as you see fit, unless you want me to take a stab at it. (I haven't pushed our release pipeline before.)

@sbc100
Copy link
Member

sbc100 commented May 12, 2023

Please go ahead and create the release.

@sbc100 sbc100 merged commit 963f973 into main May 12, 2023
@sbc100 sbc100 deleted the release-1.0.33 branch May 12, 2023 21:56
@keithw
Copy link
Member Author

keithw commented May 13, 2023

Done.

@steven-johnson
Copy link
Collaborator

steven-johnson commented May 15, 2023

I just updated Halide to use this release, and now compiling on OSX fails with:

/Users/srj/GitHub/Halide/build/release/_deps/wabt-src/src/sha256.cc:22:10: fatal error: 'picosha2.h' file not found
#include "picosha2.h"
         ^~~~~~~~~~~~

And on Linux, we fail at link time with undefined reference to 'SHA256'

@steven-johnson
Copy link
Collaborator

steven-johnson commented May 15, 2023

Update: looks like there are submodules now, and CMake's FetchContent doesn't fetch them by default, so this may be a Halide bug.

Update 2: forcing CMake to fetch the submodules, and also defining USE_INTERNAL_SHA256=ON, seems to have fixed our issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants