Skip to content

Fix #2203#2204

Merged
keithw merged 3 commits intoWebAssembly:mainfrom
SoniEx2:patch-1
Apr 21, 2023
Merged

Fix #2203#2204
keithw merged 3 commits intoWebAssembly:mainfrom
SoniEx2:patch-1

Conversation

@SoniEx2
Copy link
Collaborator

@SoniEx2 SoniEx2 commented Apr 20, 2023

(didn't test locally but should work)

Fixes #2203

@sbc100 sbc100 requested a review from keithw April 20, 2023 19:03
Copy link
Member

@keithw keithw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for working on this! Could you please submit the test to the exception-handling repo so it can get picked up by the testsuite repo and included in the WABT testsuite (#2203 (comment))?

Alternately, I think it would be fine to amend this PR to include that as a one-off test if you just want this to get merged ASAP, and we can merge the upstream testsuite fix down the road. Either way it would be nice to make sure this scenario gets tested so different implementations all agree on the behavior of mixing br with try/catch.

Copy link
Member

@keithw keithw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will be great when the upstream repo includes some tests of br interacting with try/catch. Thank you for testing and fixing this.

@keithw keithw enabled auto-merge (squash) April 21, 2023 06:54
@keithw keithw merged commit d8a966d into WebAssembly:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm2c exception handling is broken

2 participants