Added support for multi-memory in apply-names #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Feb 17, 2022
|
|
||
| Result NameApplier::OnMemoryCopyExpr(MemoryCopyExpr* expr) { | ||
| CHECK_RESULT(UseNameForMemoryVar(&expr->srcmemidx)); | ||
| CHECK_RESULT(UseNameForMemoryVar(&expr->destmemidx)); |
Member
There was a problem hiding this comment.
Could we write a test (or add to an existing test) to show that this working?
sbc100
reviewed
Feb 17, 2022
| @@ -0,0 +1,25 @@ | |||
| ;;; TOOL: run-roundtrip | |||
Member
There was a problem hiding this comment.
How about calling this apply-memory-names.txt to match the existing apply-global-names.txt
sbc100
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the multi-memory proposal in
apply-names.cc. This change should have been part of #1751, but I didn't realize that this change is necessary.This PR also adds name application to all exports. The current main branch only applies names if the export is of type
func, but I think it should also apply names forglobal,table,memory, andtag. Is there any specific reason for only applying names tofuncs?