Dont expect indices in validation messages either.#1089
Merged
sunfishcode merged 1 commit intoWebAssembly:masterfrom Oct 20, 2019
Merged
Dont expect indices in validation messages either.#1089sunfishcode merged 1 commit intoWebAssembly:masterfrom
sunfishcode merged 1 commit intoWebAssembly:masterfrom
Conversation
Similar to WebAssembly#1076, don't include index numbers in expected error messages from validation. This allows implementations to avoid creating dynamically formatted strings for validation error messages. Admittedly this isn't a huge burden, but it does seem like something that shouldn't be required to pass the spec test.
rossberg
approved these changes
Oct 7, 2019
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1076, don't include index numbers in expected error messages
from validation. This allows implementations to avoid creating
dynamically formatted strings for validation error messages. Admittedly
this isn't a huge burden, but it does seem like something that shouldn't
be required to pass the spec test.