Don't force spurious memory length check if list element size is 0#77
Closed
lukewagner wants to merge 1 commit intomainfrom
Closed
Don't force spurious memory length check if list element size is 0#77lukewagner wants to merge 1 commit intomainfrom
lukewagner wants to merge 1 commit intomainfrom
Conversation
alexcrichton
approved these changes
Jul 29, 2022
Collaborator
|
I was thinking a bit more about this and had a few more questions which might be good to resolve before landing this. |
Member
Author
|
Canceling as discussed in #78. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alexcrichton pointed out that the current trapping semantics require emitting a spurious length check when it's otherwise statically evident that there are no loads.