Convert CI from travis + appveyor to github actions#2646
Conversation
4288f47 to
5f4ac8b
Compare
|
Would actions be faster? (Is there data here already?) |
|
From our experience on wabt they are way faster than both appveyor and travis. @binji can attest. We basically don't see any queuing time. Plus they seem really good at aggressively killing stale jobs when you push new versions of PRs. There are lots of reasons for wanting to move away from travis, and we considered circleci too, but the consensus seems to be github actions (see the linked issue). |
ab44263 to
78d4091
Compare
cd10641 to
893e6f3
Compare
The intention is to move away from travis and appveyor which have become very slow. See: #2356
|
This is now ready for to land. Can you take anther look? I'm synchronously removing both travis and appveyor now. |
|
Sadly there a fair amount of dupliction here between the santizer jobs, but hopefully github actions will add the ability to share/inherit at some point: https://github.community/t5/GitHub-Actions/reusing-sharing-inheriting-steps-between-jobs-declarations/td-p/37849 |
kripken
left a comment
There was a problem hiding this comment.
lgtm but it would be good to confirm, if you haven't already, that intentional breaking of tests causes proper errors to be reported (e.g., I don't know github actions well enough to be sure there isn't a typo here preventing the sanitizer flags from being passed, or that even some of these jobs are not run).
| python-version: '3.x' | ||
| - uses: actions/checkout@v1 | ||
| with: | ||
| submodules: true |
There was a problem hiding this comment.
No, you are right we could remove those lines. Its harmless though.
| if: matrix.os == 'macos-latest' | ||
|
|
||
| - name: install ninja (win) | ||
| run: choco install ninja |
There was a problem hiding this comment.
there's more package managers for windows than I had any idea...
| if: matrix.os == 'windows-latest' | ||
|
|
||
| - name: mkdir | ||
| run: mkdir -p out |
There was a problem hiding this comment.
I think the actions run under the git-bash shell by default which is some kind MINGW/MSYS version of bash.
There was a problem hiding this comment.
Sorry, late to the party. If you type this into cmd, you'll get two directories -p and out. So this might be what's happening here. Iirc Windows images run PowerShell.
There was a problem hiding this comment.
Just learned: Under PowerShell mkdir -p out is an alias of mkdir -Path out, which apparently does what mkdir -p does. So, all good.
See: #2356