Describe legacy commands.#288
Merged
sunfishcode merged 1 commit intoWebAssembly:mainfrom Mar 17, 2022
Merged
Conversation
The core idea of new-style commands is that all function exports are command entrypoints, and they expect to be called on a fresh instance which lives only for the direction of the call. This is a generalization of the existing `_start` convention, which already has the expectation of a fresh instance which lives only for the direction of the call, and is one of the pieces need to enable user-defined command entrypoints which don't take string arguments and don't return an i32 status code. To show how this works in practice, the following patches implement this new behavior in wasm-ld and wasi-libc: - https://reviews.llvm.org/D81689 - WebAssembly/wasi-libc#203
2865f8a to
ed67f4c
Compare
Member
Author
|
This adds documentation for what is now the legacy application API. This documents behavior already implemented in clang and wasi-sdk, so my inclination is to merge it to document the current code. Any objections? |
sbc100
approved these changes
Mar 17, 2022
Member
sbc100
left a comment
There was a problem hiding this comment.
lgtm, but the PR title and description don't seem to describe this change.. unless I'm missing something.
linclark
approved these changes
Mar 17, 2022
Member
Author
|
Title and description updated. It was "new-style" at the time it was being developed, but now it's being subsumed by the component model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core idea of legacy commands is that all function exports are
command entrypoints, and they expect to be called on a fresh instance
which lives only for the direction of the call.
This is a generalization of the existing
_startconvention, whichalready has the expectation of a fresh instance which lives only for
the direction of the call, and is one of the pieces need to enable
user-defined command entrypoints which don't take string arguments and
don't return an i32 status code.
To show how this works in practice, the following patches implement
this new behavior in wasm-ld and wasi-libc: