tweak: refactor code to follow firefox guidelines#31
Merged
warengonzaga merged 5 commits intoWeb3Philippines:devfrom Aug 5, 2023
Merged
tweak: refactor code to follow firefox guidelines#31warengonzaga merged 5 commits intoWeb3Philippines:devfrom
warengonzaga merged 5 commits intoWeb3Philippines:devfrom
Conversation
Contributor
|
Hey @JBenedicto13 let me take a look into your changes. |
warengonzaga
requested changes
Jul 16, 2023
Contributor
warengonzaga
left a comment
There was a problem hiding this comment.
Just need a few things to change, after your changes, I'll test it in my local to see if the gas trackers are working properly. Thank you for your contribution!
warengonzaga
requested changes
Aug 5, 2023
Contributor
warengonzaga
left a comment
There was a problem hiding this comment.
@JBenedicto13 All is good except the icons.
warengonzaga
approved these changes
Aug 5, 2023
Contributor
warengonzaga
left a comment
There was a problem hiding this comment.
@JBenedicto13 perfect! Looks good to me, merging the changes to the dev branch. Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.