Skip to content

✨ tweak: add terms and definitions#27

Merged
warengonzaga merged 3 commits intoWeb3Philippines:devfrom
OnPaceCoder:NewTerms
Jul 12, 2023
Merged

✨ tweak: add terms and definitions#27
warengonzaga merged 3 commits intoWeb3Philippines:devfrom
OnPaceCoder:NewTerms

Conversation

@OnPaceCoder
Copy link
Contributor

Added some new terms with definitions

@warengonzaga
Copy link
Contributor

Hey, @OnPaceCoder did you base your code from the dev branch?

@warengonzaga warengonzaga self-requested a review July 11, 2023 14:07
Copy link
Contributor

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also kindly state what terms you added. @OnPaceCoder

@OnPaceCoder
Copy link
Contributor Author

I have added GasPrice , MerkleTree, Dapp, DEX and Tokenomics

@OnPaceCoder OnPaceCoder marked this pull request as draft July 11, 2023 14:29
@OnPaceCoder OnPaceCoder marked this pull request as ready for review July 11, 2023 14:44
@OnPaceCoder OnPaceCoder requested a review from warengonzaga July 11, 2023 15:59
Copy link
Contributor

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me, kindly check my comment for DApp.

@warengonzaga warengonzaga added tweak Enhancements (Issue/PR) waiting Waiting Response Status (Issue/PR) labels Jul 12, 2023
@warengonzaga warengonzaga added this to the v0.1.4 🌱 milestone Jul 12, 2023
Copy link
Contributor

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @OnPaceCoder, thank you for the update! Happy to merge this later after I fix the code conflict. Thank you for your contribution!

@warengonzaga warengonzaga removed the waiting Waiting Response Status (Issue/PR) label Jul 12, 2023
@warengonzaga
Copy link
Contributor

Looks like the code conflicts solves with your merge from the dev branch @OnPaceCoder will merge now.

@warengonzaga warengonzaga changed the title #19 terms and definitions added ✨ tweak: add terms and definitions Jul 12, 2023
@warengonzaga warengonzaga merged commit ad5ae52 into Web3Philippines:dev Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tweak Enhancements (Issue/PR)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants