Skip to content

Added more definitions; order terms alphabetically#24

Merged
warengonzaga merged 2 commits intoWeb3Philippines:devfrom
KennieHarold:dev
Jul 9, 2023
Merged

Added more definitions; order terms alphabetically#24
warengonzaga merged 2 commits intoWeb3Philippines:devfrom
KennieHarold:dev

Conversation

@KennieHarold
Copy link
Contributor

@KennieHarold KennieHarold commented Jul 7, 2023

Changes

  • Fix definition typo
  • Order terms alphabetically
  • Added dao, chainlink, abi, metaverse and zk proof
  • Added proposal title to erc related terms so user can have a general idea

@warengonzaga warengonzaga self-requested a review July 7, 2023 22:53
warengonzaga
warengonzaga requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @KennieHarold, this is amazing changes! However, I would recommend making some of the definitions, even more, shorter due to limits on our dashboard it might not be able to handle too many words. Would recommend max of 3 sentences.

@warengonzaga warengonzaga added tweak Enhancements (Issue/PR) waiting Waiting Response Status (Issue/PR) labels Jul 7, 2023
@KennieHarold
Copy link
Contributor Author

KennieHarold commented Jul 7, 2023

Hello @KennieHarold, this is amazing changes! However, I would recommend making some of the definitions, even more, shorter due to limits on our dashboard it might not be able to handle too many words. Would recommend max of 3 sentences.

Oh I see, let me revise the definitions if I have some time. Thanks @warengonzaga

@warengonzaga warengonzaga added in progress In Progress Status (Issue/PR) and removed waiting Waiting Response Status (Issue/PR) labels Jul 8, 2023
@warengonzaga
Copy link
Contributor

warengonzaga commented Jul 8, 2023

Hello @KennieHarold, this is amazing changes! However, I would recommend making some of the definitions, even more, shorter due to limits on our dashboard it might not be able to handle too many words. Would recommend max of 3 sentences.

Oh I see, let me revise the definitions if I have some time. Thanks @warengonzaga

Please do, thank you for your contribution!

@KennieHarold KennieHarold requested a review from warengonzaga July 8, 2023 10:07
warengonzaga
warengonzaga approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @KennieHarold thanks for update.

@warengonzaga warengonzaga removed the in progress In Progress Status (Issue/PR) label Jul 9, 2023
@warengonzaga warengonzaga merged commit 6be9bd8 into Web3Philippines:dev Jul 9, 2023
@warengonzaga
Copy link
Contributor

warengonzaga commented Jul 9, 2023

Updates for #19

@warengonzaga warengonzaga mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warengonzaga warengonzaga warengonzaga approved these changes

Assignees

@KennieHarold KennieHarold

Labels

tweak Enhancements (Issue/PR)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KennieHarold @warengonzaga