Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Web3Auth/web3auth-unity-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.1.0
Choose a base ref
...
head repository: Web3Auth/web3auth-unity-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.1.1
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jan 11, 2024

  1. Change usages of ToLower into ToLowerInvariant

    This fixes a very hard-to-spot bug where Web3Auth & OpenLogin started to give various configuration errors on some specific devices. Here is where we reported it:
    https://web3auth.io/community/t/invalid-constructor-params-invalid-environment-settings/6643
    
    It turns out all those devices were Turkish, and the character "ı" (or "dotless i" as non-Turkish people would say) was the reason. 
    
    You see, in Turkish, lowercasing/uppercasing rules are different, because we have a distinction between "I" and "İ" where "I".ToLower() == "ı" and "İ".ToLower() == "i" which makes sense in Turkish, and "I".ToLower() == "i" makes sense for any other language, but obviously these two rules don't mix well. And ToLower() uses the current culture information of the device. Which can make network.ToString().ToLower() into "maınnet" and buildEnv.ToString() into "productıon" "stagıng" or "testıng".
    
    To sum up: ToLower uses current device's region settings for lowercasing a string, which can be different for some Turkic languages. ToLowerInvariant is what should be used where this behavior doesn't make sense.
    ersagunkuruca authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ca88e8c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Merge pull request #33 from ersagunkuruca/patch-1

    Change usages of ToLower into ToLowerInvariant
    chaitanyapotti authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5f89d13 View commit details
    Browse the repository at this point in the history
  2. Fixes

    chaitanyapotti committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    6e42680 View commit details
    Browse the repository at this point in the history
Loading