Allow for both plain and pretty permalink structures#12
Merged
valendesigns merged 9 commits intodevelopfrom May 11, 2019
Merged
Allow for both plain and pretty permalink structures#12valendesigns merged 9 commits intodevelopfrom
valendesigns merged 9 commits intodevelopfrom
Conversation
Uses the built-in `get_rest_url` API to handle all situations. Return only the path from `get_rest_uri`
Collaborator
Author
|
@jkmassel could you take a look at this and let me know what you think. I've taken a different approach which addresses additional use cases. I've tested that adding and deleting key-pairs from your profile is working with both structures and reworked the test cases. |
jkmassel
approved these changes
May 10, 2019
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
✅ Works with plain permalinks
✅ Works with "Post name" permalinks (/%postname%/)
Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4 and builds on the work started in #6