-
Notifications
You must be signed in to change notification settings - Fork 651
Return post data from post delete endpoint #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone disagree with this one? Could theoretically interfere with a custom status of deleted. We could alternatively indicate this some other way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gone :)
delete would closer fit the existing naming pattern for statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other thought was using null, or setting the ID to null. These don't interfere with custom statuses at all, which is nice, but setting the value to null might drop some clients back to default handling for the field (we say to treat it as a draft if you don't get/understand the field), while changing the ID seems like it's removing important information.
|
@WP-API/amigos #reviewmerge |
|
PR needs a refresh for new Posts Controller, and status should be changed to 'delete'. @rmccue mind fixing up this PR? |
|
This one's on me, sorry. Will fix up ASAP. |
|
(Also needs unification with #789) |
|
What needs discussion here? |
|
|
Punting to Beta 2. |
|
Handling in #1224 |
Fixes #618.