This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Composer #310
Closed
Composer #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I feel like this one could probably be a bit more descriptive. :)
Member
|
+1 on this |
|
Please 👍 |
|
could use a squash (why did you add and remove composer multiple times?) and better formatting in |
Member
|
I'm happy to merge (although I don't use Composer myself, so y'all will need to let me know if it breaks), but as noted, needs to be squashed and remaining issues fixed. |
|
I'd be happy to submit a new PR for this but I don't want to step on any toes. @technosailor - would you mind if I worked up a new version that accounts for the suggestions/issues raised here? |
|
👀 |
Merged
Member
|
Closing in favor of #1157 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a composer.json file for composer-based WordPress installs.