@WP-API/amigos #reviewmerge

@joehoyle Thoughts on the build failure?

@danielbachhuber you need to add tax_query to the array of valid rest query parameters for the tests to work :)

https://github.com/WP-API/WP-API/blob/develop/lib/endpoints/class-wp-rest-posts-controller.php#L615-L628

you need to add tax_query to the array of valid rest query parameters for the tests to work :)

I know — wondering why we aren't doing that right now.

I know — wondering why we aren't doing that right now.

That is in #2273 which could use some of your feedback!!

I know — wondering why we aren't doing that right now.

tax_query wasn't allowed because you could have a taxonomy that's non-public and non-REST-enabled, and then query by that. We need to do validation on tax_query to ensure all queried taxonomies are allowed.

That's not an issue if we force the parameter to something we're building; i.e. set $tax_query = [] before we pass it through.

That's not an issue if we force the parameter to something we're building; i.e. set $tax_query = [] before we pass it through.

(i.e. it shouldn't be an issue with the way the code is written at the moment, so it should be allowed, I think)

PR triage discussion link: https://wordpress.slack.com/archives/core-restapi/p1473802292001233

Current coverage is 94.54% (diff: 100%)

Merging #2380 into develop will increase coverage by <.01%

@@            develop      #2380   diff @@
==========================================
  Files            11         11          
  Lines          3627       3629     +2   
  Methods         173        173          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3429       3431     +2   
  Misses          198        198          
  Partials          0          0          

Powered by Codecov. Last update 427564a...2a1c5fb

I don't know what to do to suppress that error, could use some help on this

After discussion in slack, this PR needs a clear description communicating what it is doing (seems to be permitting tax_query to be used in plugins); and we need to decide whether it is still desired after resolving #2799