This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Use get_comment_type() when comparing updating comment status #2753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't allow updating a comment type, however in the update code we are checking the raw value vs get_comment_type() which means a comment of type "comment" can not be updated, as that's actually an empty value in the database.
Member
|
Related core ticket that would be the IDEAL solution: https://core.trac.wordpress.org/ticket/38200 |
Member
|
@joehoyle the default value for the |
Member
Author
|
@rachelbaker I also had to modify |
Member
Author
|
@WP-API/amigos #reviewmerge |
rachelbaker
approved these changes
Oct 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't allow updating a comment type, however in the update
code we are checking the raw value vs get_comment_type() which means a
comment of type "comment" can not be updated, as that's actually an
empty value in the database.