Initial JS Refactor for V2 by tlovett1 · Pull Request #1374 · WP-API/WP-API

tlovett1 · 2015-06-30T04:41:18Z

JS has been refactored, cleaned up, and prepared for V2. Right now there are some holes such as:

Meta endpoints
Schema endpoints. Need some feedback here. Not sure these are necessary.
Post based term endpoints such as /posts/1/terms/post_tag

There is also more cleanup to do, especially surrounding documentation.

All feedback is welcome :)

Fixes #1320

rachelbaker · 2015-07-02T12:17:18Z

@tlovett1 avatar_url should now return an object

rachelbaker · 2015-07-06T12:57:22Z

@tlovett1 Can you merge develop into your branch? That will fix the PHPCS errors that are causing the build on your PR to appear as though it is failing.

@WP-API/amigos How should we approach this? I was thinking we could merge Taylor's initial pass and then iterate from there. Any objections?

danielbachhuber · 2015-07-06T14:14:44Z

How should we approach this? I was thinking we could merge Taylor's initial pass and then iterate from there. Any objections?

I'm fine with this. Before we merge though, can one of you open another issue with a checklist of the remaining changes / improvements needing to be made?

tlovett1 · 2015-07-06T14:50:53Z

@rachelbaker merged in develop.

tlovett1 · 2015-07-13T19:42:24Z

Any updates? @rachelbaker @rmccue

rmccue · 2015-07-22T12:06:42Z

@tlovett1 Is this also updated over at https://github.com/WP-API/client-js ? I'd like to ensure we maintain that repo as the canonical source for the JS for now, given that it'll probably need further updating too.

Happy to merge, would like a quick review from @mattheu or @kadamwhite first.

tlovett1 · 2015-07-22T14:09:15Z

@rmccue The client js repo is updated now.

rmccue · 2015-07-23T14:13:07Z

This should still be X-WP-Nonce, PHP just internally mangles the name.

kadamwhite · 2015-07-23T14:31:58Z

Will take a look a bit later today , thanks for tagging me Ryan

kadamwhite · 2015-07-24T14:51:16Z

This ought to go inside the IIFE—this will impact other included scripts if somebody uses a plugin to concatenate this with any of their other JS dependencies.

kadamwhite · 2015-07-24T14:57:55Z

Syntax error: should be 'undefined' === typeof response.author, as it is below. Although since we have Underscore I'd probably _.isUndefined()

kadamwhite · 2015-07-24T15:09:40Z

Looks good! Found one syntax error and a couple areas where we could clarify the code or simplify it with Underscore methods, but that's about it

tlovett1 · 2015-07-28T14:13:29Z

@rmccue worked in most of @kadamwhite's feedback (thanks!). Let me know if you need anything else.

kadamwhite · 2015-07-28T23:09:23Z

looks good

Initial JS Refactor for V2

rachelbaker · 2015-07-29T03:05:51Z

Merged #1374

Thank you @tlovett1 and @kadamwhite

Jany-M · 2016-10-17T00:10:36Z

From #1350:

Any specific updates on issues with s?
Even updating wp-api.js to the latest build, search & filter[s] both return empty and s returns all posts.
http://demo.wp-api.org/wp-json/wp/v2/posts?s=libero does not work, it just shows all posts, regardless the s.

kadamwhite · 2016-10-17T01:29:03Z

@Jany-M, the behavior of the ?search= query parameter (which should be used in place of filter[s] or s) would not be impacted by the JS client — if you're finding that search results are not appearing as expected that would be an issue with the API endpoint itself, and I'd encourage you to open an issue so we can dig into the problem and determine whether it might be a bug!

Jany-M · 2016-10-17T08:12:10Z

@kadamwhite using searchunfortunately leaves me with an empty result as well.
I opened #2847.

Refactor JS for v2

3dcc538

rachelbaker reviewed Jul 2, 2015
View reviewed changes

Comment thread wp-api.js Outdated

Copy link
Copy Markdown

Member

rachelbaker Jul 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlovett1 avatar_url should now return an object

tlovett1 added 3 commits July 2, 2015 09:45

Properly default parameters to object

74fafab

Add links to users and default guid to object

b96e98e

Default comment and ping status to closed on pages

f89c715

Merge branch 'develop' into feature/v2-js

40becb8

rmccue mentioned this pull request Jul 22, 2015

How to correctly search using the V2 javascript client #1350

Closed

rmccue added this to the 2.0 milestone Jul 22, 2015

rmccue added the Bug label Jul 22, 2015

rmccue modified the milestones: 2.0 Beta 4, 2.0 Jul 22, 2015

rmccue reviewed Jul 23, 2015
View reviewed changes

Comment thread wp-api.js Outdated

Copy link
Copy Markdown

Member

rmccue Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be X-WP-Nonce, PHP just internally mangles the name.

Fix nonce names

ccf041d

rmccue mentioned this pull request Jul 23, 2015

Merge changes from Client JS plugin. #1419

Closed

kadamwhite reviewed Jul 24, 2015
View reviewed changes

tlovett1 added 2 commits July 28, 2015 10:08

Move use strict into IIFE

183b73b

General cleanup, formatting, and a small syntax error fix

b99e3d6

rachelbaker added a commit that referenced this pull request Jul 29, 2015

Merge pull request #1374 from tlovett1/feature/v2-js

9554e03

Initial JS Refactor for V2

rachelbaker merged commit 9554e03 into WP-API:develop Jul 29, 2015

rmccue mentioned this pull request Aug 7, 2015

Client JS is broken because it's referencing the wrong API URL #1310

Closed

dave-green-uk mentioned this pull request Jun 25, 2016

Change all instances of WP-API in readme #2517

Closed

Conversation

tlovett1 commented Jun 30, 2015

Uh oh!

rachelbaker Jul 2, 2015

Choose a reason for hiding this comment

Uh oh!

rachelbaker commented Jul 6, 2015

Uh oh!

danielbachhuber commented Jul 6, 2015

Uh oh!

tlovett1 commented Jul 6, 2015

Uh oh!

tlovett1 commented Jul 13, 2015

Uh oh!

rmccue commented Jul 22, 2015

Uh oh!

tlovett1 commented Jul 22, 2015

Uh oh!

rmccue Jul 23, 2015

Choose a reason for hiding this comment

Uh oh!

kadamwhite commented Jul 23, 2015

Uh oh!

kadamwhite Jul 24, 2015

Choose a reason for hiding this comment

Uh oh!

kadamwhite Jul 24, 2015

Choose a reason for hiding this comment

Uh oh!

kadamwhite commented Jul 24, 2015

Uh oh!

tlovett1 commented Jul 28, 2015

Uh oh!

kadamwhite commented Jul 28, 2015

Uh oh!

rachelbaker commented Jul 29, 2015

Uh oh!

Jany-M commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kadamwhite commented Oct 17, 2016

Uh oh!

Jany-M commented Oct 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Jany-M commented Oct 17, 2016 •

edited

Loading