This repository was archived by the owner on Sep 24, 2018. It is now read-only.
If not namespace is provided, don't create double slashes#1355
Merged
If not namespace is provided, don't create double slashes#1355
Conversation
Member
|
I'd probably rather do a |
Member
|
I feel like this allows registered routes to skirt around namespacing their routes too easily, which is something we want to avoid. I agree with @rmccue that we should probably display a debug message. |
Member
|
Thought: |
Member
Author
|
Given the incorrect usage capture here, I'm ok with the tests at 60% given calling it will cause a notice anyway and fail the tests! |
joehoyle
added a commit
that referenced
this pull request
Aug 7, 2015
If not namespace is provided, don't create double slashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where I'm writing a full bespoke/whitelabelled API rather than adding to WordPress's routes, or them even being available, I want to not use namespaces at all.
This is probably controversial - but point being I want my api at
myserviers.com/apifor better or worse. (In this specific case I'm migrating from another API system, so I need the URLs to match the old ones as it's a drop in replacement).In this case, it's pretty easy for us to support this by just checking if a namespace was not-empty and don't add the double slashes if so.