Update API spec in explainer to match latest discussion#16
Merged
Conversation
- Fix WICG#13: Replace `pageHideTimeout` with `backgroundTimeout` and `timeout`. Allow to set them in constructor & data/url setters. - Address WICG#14: Rename `isPending` to `pending` and specify its behaviors. - Address WICG#14: Keep the low-level sync API, and mark it as chosen. - Fix WICG#6: Add `PendingGETBeacon` and `PendingPOSTBeacon`.
Collaborator
Author
|
cc @philipwalton @fergald PTAL. Please also suggest better naming than |
fergald
reviewed
Jul 29, 2022
fergald
approved these changes
Aug 1, 2022
- WICG#16 (comment) Specify when a timer will start for `timeout`
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 5, 2022
- `pageHideTimeout`
- Replace pageHideTimeout with `backgroundTimeout` and `timeout`.
- Allow to set them in constructor & via property setters.
- `isPending`
- Rename isPending to `pending` and specify its behaviors.
- `setData(data)`
- Remove setData(data) from base class PendingBeacon.
- Add subclass `PendingGetBeacon` which supports `setURL(url)`.
- Also define a new mojom method `setRequestURL(url)` to help update
browser-side beacon.
- Add subclass `PendingPostBeacon` which supports `setData(data)`.
See [the pull request][1] or [explainer][2] for more details.
[1]: WICG/pending-beacon#16 (comment)
[2]: https://github.com/WICG/unload-beacon#readme
Bug: 1293679
Change-Id: I8b73bdd3de7f5e8a3358564be52e2c0f2f6774de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789544
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1031758}
mingyc
added a commit
that referenced
this pull request
Sep 14, 2022
Collaborator
|
I think in the case of
I think Tab A's map.company.com beacons should still be delivered because
In general I would really like to not impose restrictions on beacon that are not present already because all that does is keep devs doing things the hard way which also tends to be wasteful of user resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pageHideTimeoutsupport additional events #13:pageHideTimeoutwithbackgroundTimeoutandtimeout.setData()orsetURL().isPending's value is unclear after deactivate() #11: RenameisPendingtopendingand specify itsbehaviors.
setData(data)only support POST request #6:PendingGETBeaconwhich supportssetURL(url, options).PendingPOSTBeaconwhich supportssetData(data, options).setData(data)from basePendingBeacon.