This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Merged
Conversation
In order to share common structure with Web Platform Tests, this PR migrates hard-coded Jest tests into JSON test metadata (`__tests__/json/*.json`, which are shared with https://github.com/web-platform-tests/wpt/tree/master/import-maps/common/resources) and test runners (`__tests__/helpers/`, which are Jest-specific).
Collaborator
Author
|
@domenic WDYT? |
domenic
approved these changes
Jan 29, 2020
Collaborator
domenic
left a comment
There was a problem hiding this comment.
This looks great, thank you!
In the future I'll probably want to pull the JSON files in from the web platform tests repo directly so that we only have one source of truth. But for now this is perfect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to share common structure with Web Platform Tests #170,
this PR migrates hard-coded Jest tests into
JSON test metadata (
__tests__/json/*.json, which are shared withhttps://github.com/web-platform-tests/wpt/tree/master/import-maps/common/resources)
and test runners (
__tests__/helpers/, which are Jest-specific).