Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Clarification: #176 and invalid URLs #184

@hiroshige-g

Description

@hiroshige-g

#176 changed the behavior around invalid URLs. i.e.

{"imports": { "https://example.com/foo": "https://:invalid:url" }}

is equal to

What was the reason behind this change?

Does this mean that, after #176, when we re-enable fallback/built-in modules support again:

  1. {"imports": { "https://example.com/foo": "https://:invalid:url" }} is equal to {"imports": {}} as a direct result of the change Slim down to a minimal core #176,
  2. {"imports": { "https://example.com/foo": ["https://:invalid:url"] }} is equal to {"imports": {}} for keeping equivalence between "https://:invalid:url" and ["https://:invalid:url"] that held before Slim down to a minimal core #176,
  3. {"imports": { "https://example.com/foo": [] }} is equal to {"imports": {}},
  4. {"imports": { "https://example.com/foo": null }} is different from {"imports": { "https://example.com/foo": [] }}

?

Context: Chromium will keep fallback implementation behind built-in modules flag, even after #176, and thus I'd like to clarify the background/implication of #176 to the fallback mechanism.
I'm neutral about the new/old behaviors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions