Skip to content

Refactoring classes and properties #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 33 commits into from
Mar 15, 2022
Merged

Refactoring classes and properties #17

kmruehl merged 33 commits into from
Mar 15, 2022

Conversation

@kmruehl
Copy link
Collaborator

@kmruehl kmruehl commented Feb 18, 2022 •
edited
Loading

WEC-Sim application updates related to WEC-Sim/WEC-Sim#803

Tests

  • B2B
  • Cable
  • Desalination
  • End Stops
  • Free Decay
    • Morison
  • Generalized Body Modes
  • Mooring
    • MooringMatrix
    • MoorDyn
  • MCR
    • PCT
      NOTE: There are no tests for PCT, consider adding test to applications repo
  • Nonhydro
  • Nonlinear Hydro
  • Paraview
    • RM3 MoorDyn
    • OSWEC nonlinear
  • Passive Yaw
    • On/Off
    • Regression
      NOTE: body1_irregYaw_disp_yaw and body1_irregYaw_torque_yaw tests are failing, @dforbush2 looking into issue
  • Traditional Morison
    • hydroBody
    • morisonElement
  • Wave Markers
  • WECCCOMP
    NOTE: not currently run on CI, refer to this note
    NOTE: https://github.com/WEC-Sim/WECCCOMP/tree/dev now running, consider moving to applications repo
  • writeCustomH5

@kmruehl kmruehl changed the base branch from master to dev March 2, 2022 18:48
@kmruehl kmruehl changed the title Variable cleanup DRAFT: Variable cleanup Mar 2, 2022
@kmruehl kmruehl changed the title DRAFT: Variable cleanup DRAFT: Refactoring classes and properties Mar 8, 2022
@kmruehl kmruehl requested review from akeeste and nathanmtom March 10, 2022 00:44
@kmruehl kmruehl mentioned this pull request Mar 10, 2022
Merged
73 tasks
@kmruehl kmruehl mentioned this pull request Mar 10, 2022
Merged
75 tasks
@kmruehl kmruehl mentioned this pull request Mar 11, 2022
Closed
@kmruehl
Copy link
Collaborator Author

kmruehl commented Mar 11, 2022 •
edited
Loading

@nathanmtom and @salhus I still can't figure out the issue with the WECCCOMP case. The WaveMarker case is working with WEC-Sim dev and kmruehl variableCleanup, but I can't seem to get the WECCCOMP case working. Any thoughts?

@kmruehl kmruehl changed the title DRAFT: Refactoring classes and properties Refactoring classes and properties Mar 14, 2022
@kmruehl
Copy link
Collaborator Author

kmruehl commented Mar 15, 2022

@WEC-Sim/wec-sim-lab-team I'm going to merge this PR into dev and re-open a new one to resolve the remaining issues

@kmruehl kmruehl merged commit 10942a9 into WEC-Sim:dev Mar 15, 2022
@kmruehl kmruehl deleted the variableCleanup branch March 29, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akeeste akeeste Awaiting requested review from akeeste

@nathanmtom nathanmtom Awaiting requested review from nathanmtom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kmruehl @akeeste