Skip to content

Extract mask variable #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanmtom merged 4 commits into from
Nov 21, 2022
Merged

Extract mask variable #958

nathanmtom merged 4 commits into from
Nov 21, 2022

Conversation

@salhus
Copy link
Contributor

@salhus salhus commented Oct 11, 2022

This PR helps in extracting the mask variables. This PR introduces a new function in the following directory,
#\source\functions\simulink\mask

To use this function,

  • Open the WEC-Sim model where the mask to be extracted resides.
  • In the argument enter the address for the mask including the Simulink model name.
  • For example: mask = ExtractMaskVariables('RM3/Float')

@salhus salhus requested a review from nathanmtom October 11, 2022 21:01
@salhus
Copy link
Contributor Author

salhus commented Oct 12, 2022 •
edited
Loading

Hi @nathanmtom ,
I added the relevant documentation to the PR. This should be ready to merge. I am not sure why some checks are failing because the document built on my end as it should have been.

H0R5E
H0R5E reviewed Nov 9, 2022
View reviewed changes
docs/developer/advanced_features.rst Outdated

* Open the pertinent Simulink model,
* Run the function with the address of the block being probed as the argument,
* Explore the :code:`mask' data structure in the MATLAB workspace.
Copy link
Contributor

@H0R5E H0R5E Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salhus, mask needs to be delimited by two `s, i.e. :code:`mask` not :code:`mask'.

Copy link
Contributor

@H0R5E H0R5E Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this line in the build logs.

Copy link
Contributor Author

@salhus salhus Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@H0R5E Thanks so much Matthew! I appreciate the help!

@nathanmtom
Copy link

nathanmtom commented Nov 21, 2022

The checks are now passing and will move forward with merging.

@nathanmtom nathanmtom merged commit 69d7894 into WEC-Sim:dev Nov 21, 2022
@salhus salhus deleted the ExtractMaksVariable branch May 30, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanmtom nathanmtom Awaiting requested review from nathanmtom

1 more reviewer

@H0R5E H0R5E H0R5E left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@salhus @nathanmtom @H0R5E