Customizable DOFs for plotBEMIO #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does what it says on the can. Handy feature. Only confusion is over how the multi DOF correspond to the hydro structures that come after. One line of documentation and feel free to merge this. |
Contributor
|
I actually have immediate need for enhancement #1, allowing plotting of off diagonal terms. with your permission I can implement this? If you'd prefer this be a separate PR no problem. |
Contributor
|
Actually! hold off on merge please. I will need to get push access to make some very minor mods. The "for" loop indexing was unintentionally Python-style in a few places. I also added the changes to allow plotting of off diagonals as well |
Contributor
|
This is ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to input custom DOFs into
plotBEMIOand the other BEMIO plotting functions (plotAddedMass,plotRadiationDamping, etc).This allows users to easily visualize sway, roll, yaw or GBM modes. The
plotBEMIOfunction will use surge, heave, pitch by default if no DOF list is input. If called individually, the BEMIO plotting functions need adofListvariable defined, e.g.:Other ways to further expand this could be enabling: