Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Jun 13, 2022

This PR addresses issue #867. The command to run('stopWecSim') can be moved to the wecSim.m file so that MATLAB can show more explicit errors for post-processing. The documentation will likely need to be updated in order to adjust the runFromSimulink workflow to include running stopWecSim after running the Simulink model.

@akeeste
Copy link
Contributor

akeeste commented Jun 14, 2022

Hi @jtgrasb

Yes thanks for doing this. Can you also:

  • remove the last comments in wecSim.m as they are now outdated
  • update the steps in the documentation. This should primarily be updating the bulleted lists to include another step "Type stopWecSim in the Command Window"

@akeeste akeeste linked an issue Jun 15, 2022 that may be closed by this pull request
@kmruehl kmruehl requested a review from akeeste June 15, 2022 14:35
@jtgrasb
Copy link
Contributor Author

jtgrasb commented Jun 24, 2022

@akeeste Updated, thanks for the suggestions!

@kmruehl
Copy link
Collaborator

kmruehl commented Jun 29, 2022

@jtgrasb and @akeeste is this ready for a merge?

@kmruehl kmruehl added the SCM source code mangagement and warnings label Jun 29, 2022
@kmruehl
Copy link
Collaborator

kmruehl commented Jun 29, 2022

merging now.

@kmruehl kmruehl merged commit 68278c3 into WEC-Sim:dev Jun 29, 2022
@jtgrasb jtgrasb deleted the StopFcn_Error branch June 29, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM source code mangagement and warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Developer Issue] stopWecSim warnings

3 participants