Fix saveViz #866
Fix saveViz #866
Conversation
akeeste
left a comment
There was a problem hiding this comment.
@jtgrasb Thanks for this fix, this works fine as is. But let's use the import body geometry function that is already in the bodyClass. This way we can also take advantage of the geometry checks that are contained there. Then we can use the geometry.vertex and geometry.face as is. Alternatively we could run importBodyGeometry in the pre-processing for all cases, instead of just for the nonlinear hydro ones.
I'll change this to be into master as well since it's a bug fix.
Adam
source/objects/responseClass.m
Outdated
| % Read and assign geometry data | ||
| bodyMesh(ibod).Points = body(ibod).geometry.vertex; | ||
| bodyMesh(ibod).Conns = body(ibod).geometry.faces; | ||
| readBodyMesh = stlread(body(ibod).geometryFile); |
There was a problem hiding this comment.
Alternate option:
if isempty(body(ibod).geometry.vertex)
% Import body geometry for linear hydro cases
body(ibod).importBodyGeometry(simu.domainSize);
end
bodyMesh(ibod).Points = body(ibod).geometry.vertex;
bodyMesh(ibod).Conns = body(ibod).geometry.face;
There was a problem hiding this comment.
Thanks for the suggestion @akeeste! I do think it may be useful to import geometry for all cases to have those checks. We can discuss further with the team in our next meeting.
This PR is in reference to Issue #864 and updates the saveViz feature to work with the v5.0 release.