Skip to content

Conversation

@salhus
Copy link
Contributor

@salhus salhus commented Apr 22, 2022

Added a line to add a phase offset to the phase data extracted from aqwa to account for the different sign conventions used.

Thus follows from #846

@salhus salhus requested review from kmruehl and nathanmtom April 22, 2022 23:08
@kmruehl kmruehl added Bug bug in WEC-Sim source, high priority BEM/BEMIO related to BEMIO or BEM hydro data Wave Class Wave Classs (waveClass.m) labels Apr 26, 2022
@kmruehl
Copy link
Collaborator

kmruehl commented Apr 26, 2022

Thanks @salhus !

@kmruehl kmruehl merged commit 42b4ef5 into WEC-Sim:master Apr 26, 2022
@salhus
Copy link
Contributor Author

salhus commented Apr 27, 2022

Thanks for merging it @kmruehl !

@salhus salhus deleted the aqwa-phase-convention-change branch April 27, 2022 15:53
@tuisong1106
Copy link

Dear Salhus, the phase of excitation force read by this program is not consistent with the value in LIS file. Could you please help test whether the program needs to be improved? Thank you.

@salhus
Copy link
Contributor Author

salhus commented May 8, 2022

@tuisong1106
Could you please share some examples, with if possible the time histories?
That will help me understand the potential issue.

@tuisong1106
Copy link

@tuisong1106 Could you please share some examples, with if possible the time histories? That will help me understand the potential issue.

I used AQWA to calculate the interaction between two cylinders, and the reading program found that the excitation force was not matched, and the added mass and radiation Damping were opposite in the upper right corner (the influence of 1 on 2) and the lower left corner (the influence of 2 on 1).

@salhus
Copy link
Contributor Author

salhus commented May 9, 2022

@tuisong1106
Thanks for describing the issue.
However, it will help me understand if you can share the actual files .
The hydrodynamic couplings are typically symmetric matrices so I am not sure I followed what opposite implies.

Cheers,
Sal

@kmruehl
Copy link
Collaborator

kmruehl commented May 11, 2022

@tuisong1106 and @salhus can you open a new issue and move this discussion to it? thank you.

@kmruehl
Copy link
Collaborator

kmruehl commented May 12, 2022

Thanks @salhus

@salhus
Copy link
Contributor Author

salhus commented May 18, 2022

Hi @tuisong1106 ,
Just checking in with you about the issue. I have opened an issue where this can be addressed.
sal

This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEM/BEMIO related to BEMIO or BEM hydro data Bug bug in WEC-Sim source, high priority Wave Class Wave Classs (waveClass.m)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants