Bug fix for the regular wave power full expression #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling Dev into Nathan's Branch
Adding more text, images, and implementation details.
Continuing to update the development pages for the Morison Element implementation.
There was a bug in the regular wave power full expression, requiring a 2 factor in the sinh function. In addition, changing from the hard coded 9.81 to simu.g.
Collaborator
|
Thanks @nathanmtom, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described in #836 has demonstrated that there is was an error in the full expression (intermediate and shallow water) for regular waves. The expression requires an extra factor of two within the
sinhfunction which is important assinhhas near or larger than exponential growth past an argument of one. Since this is in the denominator of the expression it can dramatically over estimate wave power. Furthermore, in the full expression for the irregular wave case, there was a hard coded 9.81 which was converted tosimu.g.