Refactoring - Update class setAccess and getAccess #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kmruehl
reviewed
Mar 23, 2022
kmruehl
reviewed
Mar 23, 2022
kmruehl
reviewed
Mar 23, 2022
kmruehl
reviewed
Mar 23, 2022
kmruehl
reviewed
Mar 23, 2022
Collaborator
|
@akeeste it looks like there are some conflicts with dev now, please resolve. I'm also going to resolve them on my branch |
Collaborator
|
@akeeste tests are failing due to Error occurred while setting up or tearing down regressionTest.
As a result, all regressionTest tests failed and did not run to completion.
---------
Error ID:
---------
'MATLAB:noSuchMethodOrField'
--------------
Error Details:
--------------
Unrecognized method, property, or field 'checkinputs' for class 'waveClass'.
Error in initializeWecSim (line 93)
waves.checkinputs();
Error in run (line 91)
evalin('caller', strcat(script, ';'));
Error in wecSim (line 44)
run('initializeWecSim');
Error in runLoadRegular (line 25)
wecSim; % Run Simulation |
Collaborator
|
@akeeste I think it's a case issue, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some refactoring items, namely updates the
setAccessandgetAccessof various class properties based on how they are used. SomesetX()methods are added so that properties can be private-public while still set ininitializeWecSimnumberproperties private-public.setNumber()methods so thatnumberproperties can still be set ininitializeWecSimmooring.orientationas it is not used anywhere. Note, this is not used in the same way as the other classeswaves.typeto private-public.typeNumis set privately and only in the class constructor sotypemust be set through the constructor as wellbody.geometry, body.h5Fileto private-public and update the docstring so that the API pulls the full descriptionbody.dofCoupled, body.totalto private-public and defined in abody.setup()methodbody.hydroTotal, not usedbody.massCalcMethodto private-public and removed frominitializeWecSimline 149. This should not be called theresimu.cicTime, simu.cicLength, simu.caseFile, simu.date, simu.gitCommit, simu.maxIt, simu.outputDir, simu.wsVersionto private-public, not used outside of the simulationClasssimu.inputFile, simu.logFile, not used