Skip to content

Update BEMIO tests and documentation #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 19 commits into from
Mar 2, 2022
Merged

Update BEMIO tests and documentation #812

kmruehl merged 19 commits into from
Mar 2, 2022

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Feb 24, 2022 •
edited
Loading

This PR:

  • Turns compareBEM into BEMIO test scripts
  • Reorganizes BEMIO tests in an attempt to reuse data within the test and decrease runtime
  • Updates the BEMIO documentation to an API doc
  • minor update to responseClass API doc to fix duplication issue described at the end of Update response class API #802
  • Removes Write HDF application from documentation (functions are outdated and were removed in BEMIO Cleanup #790)
  • remove outdated bodyClass.loadH5File() method (should have been removed in BEMIO Cleanup #790)
  • Update formatPlot to take hydro structs with different number of bodies
  • Updates convention for BEM names in documentation (i.e. Aqwa instead of AQWA and Capytaine instead of CAPYTAINE)

akeeste added 16 commits February 21, 2022 09:54
@akeeste akeeste added BEM/BEMIO related to BEMIO or BEM hydro data Documentation related to docs Tests/CI related WEC-Sim tests or Continuous Integration labels Feb 24, 2022
@akeeste akeeste mentioned this pull request Feb 24, 2022
Merged
@kmruehl
Copy link
Collaborator

kmruehl commented Feb 24, 2022

@akeeste can you change this to a merge with dev?

@kmruehl kmruehl self-requested a review February 24, 2022 21:51
@akeeste akeeste changed the base branch from master to dev February 24, 2022 22:31
@akeeste
Copy link
Contributor Author

akeeste commented Mar 2, 2022

Fixed the sphere path in bemioTest, this is ready now. Our BEMIO/Capytaine examples are apparently named differently than the other BEMIO examples (Capytaine examples use all lower-case directories)

@kmruehl kmruehl merged commit 0354c10 into WEC-Sim:dev Mar 2, 2022
@akeeste akeeste mentioned this pull request Mar 2, 2022
Closed
@akeeste akeeste deleted the bemioTestDocs branch March 3, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmruehl kmruehl Awaiting requested review from kmruehl

Assignees

No one assigned

Labels

BEM/BEMIO related to BEMIO or BEM hydro data Documentation related to docs Tests/CI related WEC-Sim tests or Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akeeste @kmruehl