Update to normalize for mean drift force in dev #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling Dev into Nathan's Branch
Adding more text, images, and implementation details.
Continuing to update the development pages for the Morison Element implementation.
This update is correcting a sorting issue that the mean drift force field within the hydro structure was not completing.
Other instances where the function exist needs to be replaced.
The surge and sway mean drift forces were being normalized by \rho and g inside of readNEMOH in addition to normalizeBEM.m. For consistency removed normalization of the mean drift force within readNEMOH.
Collaborator
|
@nathanmtom this looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same code changes as PR #808 , but in the next WEC-Sim release we are planning to have several variable and function name changes. This PR is an attempt to make the update to a future WEC-Sim easier.