Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Feb 23, 2022

In this pull request, I simply removed the passiveYawTest.m testing script as they were moved to the WEC-Sim Applications repo. These tests were failing when I tried to run tests locally, and it seems like they were supposed to be fully removed with PR #738.

@akeeste akeeste self-requested a review February 24, 2022 18:32
@akeeste
Copy link
Contributor

akeeste commented Feb 24, 2022

@jtgrasb It makes sense to me to remove this. I see that:

  1. this test is not called in WEC-Sim by wecSimTest, so it is not normally used
  2. the WEC-Sim_Applications passive yaw case contains the irregular regression test

The only missing component is that the regular wave passive yaw regression test is not included in the applications repo. @kmruehl Did we mean to move this too or do we only want to use the irregular wave regression for passive yaw?

Adam

@akeeste akeeste added SCM source code mangagement and warnings Tests/CI related WEC-Sim tests or Continuous Integration labels Feb 24, 2022
@kmruehl
Copy link
Collaborator

kmruehl commented Feb 24, 2022

@jtgrasb yes, it looks like this file should have been removed before and we need to make sure it gets migrated to the applications repository. I noted this in PR #803 along with a few other open questions for the team.

@kmruehl kmruehl merged commit e735f16 into WEC-Sim:dev Feb 24, 2022
@jtgrasb jtgrasb deleted the removePassiveYawTestFIles branch July 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM source code mangagement and warnings Tests/CI related WEC-Sim tests or Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants