Wave class wave gauge update #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 30, 2021 15:52
Pulling Dev into Nathan's Branch
Adding more text, images, and implementation details.
Continuing to update the development pages for the Morison Element implementation.
Now that we have the waves.markerLoc which is already generating the undisturbed wave elevation there was not need to have separate variables to output these same values. This PR will remove all incidences of wavegauge(i)loc variables.
Collaborator
|
@salhus have you had a chance to review this PR? |
Contributor
|
@kmruehl @nathanmtom Sorry about the delay in reply. I went through all of the commits and looks good to me. Thanks for using the prior updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is eliminating the wavegauge(i)loc variables that were developed as part of WECCCOMP. With the updates to the WEC-Sim visualization features by @salhus we are repeating the process of defining points of interest in the wave field to calculate the undisturbed wave elevation. This pull request will remove the functionality and appearance of the previous wavegauge(i)loc variables. Updates will be made to the WEC-Sim applications and WECCCOMP repositories for continued use after this PR is accepted.