Update documentation on mean drift and current #800
Conversation
|
@nathanmtom offered to review the current documentation. @yuyihsiang can you reviewthe mean drift documentation, or recommend someone else to review it? |
nathanmtom
left a comment
There was a problem hiding this comment.
@akeeste Thanks for updating the documentation. Other than my two minor edits, this looks good from my end @yuyihsiang might have more comments on the mean drift description.
Also, we probably need to add cards to add to our documentation on this realization of the second order drift forces. @yuyihsiang can comment but not sure if we are solving the second order problem or using an approximation based on first order diffraction coefficients.
|
@akeeste I got some initial feedback from Toan and his comment about the documentation was to change the mean drift force description as follows: "The mean drift term can optionally be included if mean drift force coefficients are defined in the BEM data." I think next week it would be worth having a short call with Toan to double check our implementation and discuss how we can expand our documentation on the mean drift implementation. |
|
This PR addresses project card https://github.com/WEC-Sim/WEC-Sim/projects/58#card-72526916
It adds minor doc updates to clarify how/when the mean drift force and waves.current options are used.
To my understanding mean drift and current each have one scenario they affect: