Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Nov 1, 2021

This PR updates WEC-Sim to allow users to use binary stl files. It removes the custom import_stl_fast function and instead uses the MATLAB supported stlread function which supports binary and ASCII STL files. stlread runs as or more quickly than import_stl_fast.

Resolves issue #748.

@akeeste akeeste added Body Class Body Class (bodyClass.m) Feature new feature request labels Nov 1, 2021
@akeeste akeeste linked an issue Nov 1, 2021 that may be closed by this pull request
Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akeeste this all looks good to me, but we need to revisit the discussion with the team about whether this is the direction we want to go. Also, we need to revise the NOTICE file to remove the import_stl_fast dependency.

@kmruehl kmruehl added the Mesh related to BEM or non-lineary hydro mesh label Nov 17, 2021
@kmruehl kmruehl merged commit 3454924 into WEC-Sim:dev Nov 17, 2021
@akeeste akeeste deleted the binarySTL branch November 17, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Body Class Body Class (bodyClass.m) Feature new feature request Mesh related to BEM or non-lineary hydro mesh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error when generating the vtk directory for Paraview

2 participants