Run from sim updates #737
Run from sim updates #737
Conversation
There was a problem hiding this comment.
@akeeste all of the revisions to the SimulinkMaskFunctions look good and I'd like to merge, but I want to make sure the updates do not conflict with the current library PR(s). Right now there is a merge conflict with the Frames library. I don't think this is a priority for v4.4, but if you have time to resolve conflicts once the other library PRs are merged we can include it.
|
I have pulled the most recent version of dev into this branch. The library update renames three mask parameters for the Run From Simulink functionality. For all blocks, these parameters are renamed in the following manner: This should make the Run From Simulink callbacks more clear to read and understand. Also, I moved the button to load parameters from an input file to a mask, into the "custom parameter" section of the Global Reference Frame mask since that is where it is actually used: |
|
@akeeste this looks good to me. Thanks for cleaning up the run from Simulink functions. Are there any doc updates you'd like to make to the http://wec-sim.github.io/WEC-Sim/dev/developer/library.html#library-development section based on this PR? |
|
@kmruehl I double checked the docs. I updated a couple images since the mask variable names change slightly, but otherwise the content in that section is not affected. |
|
@akeeste you may want to delete this branch |
This PR clean up various Run From Simulink items. It is composed of all changes that were split from PR #728. No functional changes are made, only refactoring of the mask callbacks for clarity.