@salhus This mask fix looks good! However there were other changes to the Frames library on Friday. Can you base this on the most recent version of dev and the copy your mask update back into the library? Or if you give me push access I'm happy to do this too.

No need to open another PR, I would recommend force pushing any changes to this same branch. After that I'll quickly review once more to ensure things work on dev.

Thanks!
Adam

@akeeste Thanks! I gave you access to the branch.
I didn't quite follow how to force push though. When i open the branch in browser, it gives me an option to fetch master and not dev// So i was confused how to do that without a new PR..

Hi @salhus

I don't know how to do this on GitHub in a browser; I would usually do this locally in the git command line with something like:

git reset --hard upstream/dev
*make mask change on top of dev and commit*
git push --force salhus/indexFix

There is likely a similar process if you are using GitHub Desktop

You could try the library merge tool too, but if your mask change is isolated in one block it is likely easier to reset to dev and put your changes on top. I can take a look in the next couple of days when I get a chance.

Adam

Hi @akeeste ! thanks ! I learnt something new. Didn't know how to do this before...!!

@akeeste Cheers mate !

Thanks for helping with the finishing touches :)