Skip to content

Conversation

@kmruehl
Copy link
Collaborator

@kmruehl kmruehl commented Aug 25, 2021

This PR started as an effort to build on @salhus's #685 to move the 'temp' directory creation into the $CASE directory for each run, and morphed into a few more things:

  • moved the 'temp' directory creation into the $CASE directory for each run
  • updated WEC-Sim to R2020a (i.e. saved Library in R2020a) to align with WEC-Sim tests, now supporting R2020a and newer
  • renamed activate_wecsim and deactivate_wecsim to addWecSimSource and removeWecSimSource for camelCase compliance.
  • renamed wecSimInitialize --> initializeWecSim and wecSimStopFunction --> stopWecSim for consistency.
  • updated RM3FromSimulink example to have simu.rampTime = 100s from custom input
  • removed wecSimStartup and will use addWecSimSource instead
  • updated docs to reflect above changes

Note:
Several of these name changes were to reduce the number of autocomplete options when you type wecSim into the command window. Ideally, anything that starts with wecSim is a script that executes WEC-Sim, e.g. wecSim, wecSimMCR, wecSimPCT, wecSimFcn. I'm on the fence about wecSimTest, thoughts?

@kmruehl kmruehl requested a review from akeeste August 25, 2021 22:51
@kmruehl kmruehl added Feature new feature request SCM source code mangagement and warnings labels Aug 25, 2021
@kmruehl kmruehl merged commit 9b8cdbd into WEC-Sim:dev Aug 27, 2021
@kmruehl kmruehl deleted the feature_temp branch August 27, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature new feature request SCM source code mangagement and warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants