Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Jul 19, 2021

The links in the applications section of the documentation were leading to errors so I updated them to refer and link to the correct sections.

@akeeste akeeste self-assigned this Jul 19, 2021
@akeeste akeeste added the Documentation related to docs label Jul 19, 2021
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffalo1 This PR looks good! Thanks for updating these URLs. I made a few small in line comments.

My main request is to also change the rest of the documentation URLs to the :ref: format For example if I CTRL+F in all rst files for "wec-sim.github.io/WEC-Sim" I see one outdated link in overview.rst and several in release_notes.rst

@jtgrasb
Copy link
Contributor Author

jtgrasb commented Jul 21, 2021

@akeeste I fixed all the links that contained "wec-sim.github.io/WEC-Sim" so it should be done now. I also changed some other links before I realized an issue on my end so that is the reason for the extra commits/reverts. Let me know if there's any other issues you find.

Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff, all these links work now. Merging!

@akeeste akeeste merged commit 637e9ce into WEC-Sim:dev Jul 21, 2021
@jtgrasb jtgrasb deleted the documentation_changes branch July 21, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants