Skip to content

Update waveClass in reference to issue #558 #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 1 commit into from
Apr 30, 2021
Merged

Update waveClass in reference to issue #558 #570

kmruehl merged 1 commit into from
Apr 30, 2021

Conversation

@nathanmtom
Copy link

@nathanmtom nathanmtom commented Apr 30, 2021

Update the calculation of the power contained within an irregular wave spectrum. There was a factor of 2\pi off in the calculation.

Update waveClass in reference to issue #564
304cdf7 
Update the calculation of the power contained within an irregular wave spectrum. There was a factor of 2\pi off in the calculation.
@nathanmtom nathanmtom requested a review from kmruehl April 30, 2021 01:06
@kmruehl kmruehl added Wave Class Wave Classs (waveClass.m) Bug bug in WEC-Sim source, high priority labels Apr 30, 2021
kmruehl
kmruehl approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathanmtom

@kmruehl kmruehl merged commit ac91916 into WEC-Sim:master Apr 30, 2021
@kmruehl kmruehl mentioned this pull request Apr 30, 2021
Closed
@nathanmtom nathanmtom mentioned this pull request May 3, 2021
Closed
@nathanmtom nathanmtom changed the title Update waveClass in reference to issue #564 Update waveClass in reference to issue #558 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmruehl kmruehl kmruehl approved these changes

Assignees

No one assigned

Labels

Bug bug in WEC-Sim source, high priority Wave Class Wave Classs (waveClass.m)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nathanmtom @kmruehl