Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Dec 17, 2020

This PR fixes issue #479 where the 'Drag body' label appears on a rigid body if the Variant variables are not yet defined. This causes confusion and can make Simulink bodies appear to be a different type than they actually are.

This fix uses the 'Allow zero active variant controls' option in the rigid body which allows no label to be assigned until a body is one of the Variants is correctly activated. This requires the library to be in R2017b or later.

@akeeste akeeste self-assigned this Dec 17, 2020
@akeeste akeeste added the Bug bug in WEC-Sim source, high priority label Dec 17, 2020
@akeeste akeeste linked an issue Dec 17, 2020 that may be closed by this pull request
@kmruehl kmruehl changed the title Variant subsystem label fix Variant subsystem label fix resolves #479 Dec 17, 2020
@kmruehl kmruehl self-requested a review December 17, 2020 19:37
@kmruehl
Copy link
Collaborator

kmruehl commented Dec 17, 2020

This PR fixes issue #479 where the 'Drag body' label appears on a rigid body if the Variant variables are not yet defined. This causes confusion and can make Simulink bodies appear to be a different type than they actually are.

This fix uses the 'Allow zero active variant controls' option in the rigid body which allows no label to be assigned until a body is one of the Variants is correctly activated. This requires the library to be in R2017b or later.

@akeeste, can you add a screenshot of what was changed in the library for reference?

Copy link
Collaborator

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akeeste this PR resolves #479! And thanks for the other cleanup.

@kmruehl kmruehl merged commit 820448c into WEC-Sim:dev Dec 17, 2020
@akeeste
Copy link
Contributor Author

akeeste commented Dec 17, 2020

I'm adding a few screenshots of what has been changed in Simulink for easy reference. The main change that fixed the actual subsystem labeling issue is changing the block parameter option "Allow zero active variant controls". I changed this in the properties table and in the mask:
image
image

As a small clean-up item, I also changed the annotations for the excitation force in each case to reflect that the mean drift force is also included. For example:
image

This is done for each of the F_exc types:
image

@akeeste akeeste deleted the variant_subsys branch December 17, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variant Subystem Rendering

2 participants