Fix spread with nonlinear hydro #1528
Conversation
|
Hello, I was reviewing the documentation for nonlinear hydro and came across this PR. I see that you changed the nonlinear FK function by moving the spreading weights under the square root: 
However, upon reviewing the waveElevation function, it appears to still have the spreading weights applied outside of the square root: 
Could you provide guidance on whether that should be the case? Thank you, Thomas |
|
@thomash303 Thank you for catching this and letting us know. You are correct that we forgot to make the change in the |
|
@jtgrasb Yeah, I can submit a pull request! |
This PR fixes the nonlinear hydro calculation for cases with wave spreading. The spread term is moved to under the square root to be consistent with our documentation and the other irregular excitation functions.
I tested this to make sure everything runs, but I did not get a chance to test a nonlinear case with spread. A quick test would be to run the OSWEC case with nonlinear hydrodynamics and an irregular wave with spread in a few directions. Then, compare the result to the same irregular wave without spread. The result should show increased excitation for the case without spread (difference depends on the spread values).