Fix for the elevation plot when multiple wave classes are defined #1526
+24
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
akeeste
approved these changes
Aug 13, 2025
| rampTime double {mustBeReal, mustBeNonNan, mustBeFinite} = 0 | ||
| end | ||
|
|
||
| waveElevationSum = zeros(size(obj(1).waveAmpTime(:,2))); |
Contributor
There was a problem hiding this comment.
This works but is quite surprising MATLAB behavior to me. I would have thought that calling an object's method on an array of objects would error, not result in the entire object array being available in the method.
akeeste
approved these changes
Aug 13, 2025
Contributor
|
tests are passing. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an error that occurs when plotting the wave elevation with multiple wave class instances. The implementation now correctly sums the
waveAmpTime(:,2)values from all wave objects before plotting, ensuring the total wave elevation is accurately represented.