Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Jul 29, 2025

Bugfix to resolve issue #1512.

Adds a rate transition block related to #1476

@akeeste akeeste added the Bug bug in WEC-Sim source, high priority label Jul 29, 2025
@akeeste akeeste linked an issue Jul 29, 2025 that may be closed by this pull request
@MShabara
Copy link
Contributor

@akeeste I did checks comparing main to dev, and comparing dev with simu.cicDT = simu.dt = 0.1 and simu.cicDT = 0.2 and the results match as seen in the fig below.

image

If the PR is done from your end, you can go ahead and merge it

@akeeste akeeste self-assigned this Jul 30, 2025
@akeeste akeeste requested a review from MShabara July 30, 2025 13:28
@akeeste
Copy link
Contributor Author

akeeste commented Jul 30, 2025

@MShabara Great, thanks! Merging.

@akeeste akeeste merged commit 307a6d3 into WEC-Sim:dev Jul 30, 2025
10 checks passed
@akeeste akeeste deleted the bugfix_rate_transition branch July 30, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error on dev when simu.cicDt is different than simu.dt

2 participants